Dynaflow refactor #130
Merged
Dynaflow refactor #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 18, 2022 11:13
- iidm version - version of Dynaflow API - Dynaflow name Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
added 3 commits
November 18, 2022 11:22
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
marcochiaramello
approved these changes
Nov 18, 2022
gautierbureau
approved these changes
Nov 24, 2022
flo-dup
requested changes
Nov 24, 2022
dynaflow/src/main/java/com/powsybl/dynaflow/DynaFlowConfig.java
Outdated
Show resolved
Hide resolved
dynaflow/src/main/java/com/powsybl/dynaflow/DynaFlowProvider.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Dupuy <66690739+flo-dup@users.noreply.github.com> Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
dimbdr
force-pushed
the
dynaflow-refactor
branch
from
f9d7286 to
e91bb63
Compare
added 2 commits
November 24, 2022 14:28
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
dimbdr
commented
Nov 24, 2022
dynaflow/src/main/java/com/powsybl/dynaflow/DynaFlowConstants.java
Outdated
Show resolved
Hide resolved
added 3 commits
November 25, 2022 15:43
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
flo-dup
requested changes
Nov 25, 2022
| @@ -74,6 +76,11 @@ public void checkExecutionCommand() { | |||
| assertEquals(expectedExecutionCommand, executionCommand); | |||
| } | |||
|
|
|||
| @Test | |||
| public void iidmCurrentVersionUsed() { | |||
| assertEquals(IidmXmlVersion.V_1_4.toString("."), IIDM_VERSION); | |||
There was a problem hiding this comment.
I think you can remove that test which is not that useful, plus it produces a code smell.
| return this.toString(DEFAULT_DELIMITER); | ||
| } | ||
|
|
||
| public static DynaFlowVersion of(String version) { |
There was a problem hiding this comment.
You could also return an Optional<DynaFlowVersion> in both DynaFlowVersion::of, it would make the code a bit clearer when checking the version don't you think? with a .map(v -> v.compareTo(version) >= 0).orElse(false) instead of catching an exception
There was a problem hiding this comment.
Oh nice, it's quite better indeed!
Done!
added 2 commits
November 25, 2022 17:15
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Mainly changing the IIDM version.